tipc: Enhancements to name table initialization

This patch enhances the initialization of TIPC's name table
by removing a pointless spinlock operation, and by using
kcalloc() to detect requests for an oversized name table.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Allan Stephens 2008-05-12 15:41:53 -07:00 committed by David S. Miller
parent 20c2c1fd6c
commit 4e3e6dcb43
1 changed files with 2 additions and 5 deletions

View File

@ -1050,15 +1050,12 @@ void tipc_nametbl_dump(void)
int tipc_nametbl_init(void)
{
int array_size = sizeof(struct hlist_head) * tipc_nametbl_size;
table.types = kzalloc(array_size, GFP_ATOMIC);
table.types = kcalloc(tipc_nametbl_size, sizeof(struct hlist_head),
GFP_ATOMIC);
if (!table.types)
return -ENOMEM;
write_lock_bh(&tipc_nametbl_lock);
table.local_publ_count = 0;
write_unlock_bh(&tipc_nametbl_lock);
return 0;
}