rtnetlink: verify IFLA_VF_INFO attributes before passing them to driver
Jason Gunthorpe reported that since commitc02db8c629
("rtnetlink: make SR-IOV VF interface symmetric"), we don't verify IFLA_VF_INFO attributes anymore with respect to their policy, that is, ifla_vfinfo_policy[]. Before, they were part of ifla_policy[], but they have been nested since placed under IFLA_VFINFO_LIST, that contains the attribute IFLA_VF_INFO, which is another nested attribute for the actual VF attributes such as IFLA_VF_MAC, IFLA_VF_VLAN, etc. Despite the policy being split out from ifla_policy[] in this commit, it's never applied anywhere. nla_for_each_nested() only does basic nla_ok() testing for struct nlattr, but it doesn't know about the data context and their requirements. Fix, on top of Jason's initial work, does 1) parsing of the attributes with the right policy, and 2) using the resulting parsed attribute table from 1) instead of the nla_for_each_nested() loop (just like we used to do when still part of ifla_policy[]). Reference: http://thread.gmane.org/gmane.linux.network/368913 Fixes:c02db8c629
("rtnetlink: make SR-IOV VF interface symmetric") Reported-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Cc: Chris Wright <chrisw@sous-sol.org> Cc: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com> Cc: Greg Rose <gregory.v.rose@intel.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Rony Efraim <ronye@mellanox.com> Cc: Vlad Zolotarov <vladz@cloudius-systems.com> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com> Cc: Thomas Graf <tgraf@suug.ch> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Vlad Zolotarov <vladz@cloudius-systems.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
6c3e921b18
commit
4f7d2cdfdd
|
@ -1328,10 +1328,6 @@ static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {
|
|||
[IFLA_INFO_SLAVE_DATA] = { .type = NLA_NESTED },
|
||||
};
|
||||
|
||||
static const struct nla_policy ifla_vfinfo_policy[IFLA_VF_INFO_MAX+1] = {
|
||||
[IFLA_VF_INFO] = { .type = NLA_NESTED },
|
||||
};
|
||||
|
||||
static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
|
||||
[IFLA_VF_MAC] = { .len = sizeof(struct ifla_vf_mac) },
|
||||
[IFLA_VF_VLAN] = { .len = sizeof(struct ifla_vf_vlan) },
|
||||
|
@ -1488,96 +1484,98 @@ static int validate_linkmsg(struct net_device *dev, struct nlattr *tb[])
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int do_setvfinfo(struct net_device *dev, struct nlattr *attr)
|
||||
static int do_setvfinfo(struct net_device *dev, struct nlattr **tb)
|
||||
{
|
||||
int rem, err = -EINVAL;
|
||||
struct nlattr *vf;
|
||||
const struct net_device_ops *ops = dev->netdev_ops;
|
||||
int err = -EINVAL;
|
||||
|
||||
if (tb[IFLA_VF_MAC]) {
|
||||
struct ifla_vf_mac *ivm = nla_data(tb[IFLA_VF_MAC]);
|
||||
|
||||
nla_for_each_nested(vf, attr, rem) {
|
||||
switch (nla_type(vf)) {
|
||||
case IFLA_VF_MAC: {
|
||||
struct ifla_vf_mac *ivm;
|
||||
ivm = nla_data(vf);
|
||||
err = -EOPNOTSUPP;
|
||||
if (ops->ndo_set_vf_mac)
|
||||
err = ops->ndo_set_vf_mac(dev, ivm->vf,
|
||||
ivm->mac);
|
||||
break;
|
||||
if (err < 0)
|
||||
return err;
|
||||
}
|
||||
case IFLA_VF_VLAN: {
|
||||
struct ifla_vf_vlan *ivv;
|
||||
ivv = nla_data(vf);
|
||||
|
||||
if (tb[IFLA_VF_VLAN]) {
|
||||
struct ifla_vf_vlan *ivv = nla_data(tb[IFLA_VF_VLAN]);
|
||||
|
||||
err = -EOPNOTSUPP;
|
||||
if (ops->ndo_set_vf_vlan)
|
||||
err = ops->ndo_set_vf_vlan(dev, ivv->vf,
|
||||
ivv->vlan,
|
||||
err = ops->ndo_set_vf_vlan(dev, ivv->vf, ivv->vlan,
|
||||
ivv->qos);
|
||||
break;
|
||||
if (err < 0)
|
||||
return err;
|
||||
}
|
||||
case IFLA_VF_TX_RATE: {
|
||||
struct ifla_vf_tx_rate *ivt;
|
||||
|
||||
if (tb[IFLA_VF_TX_RATE]) {
|
||||
struct ifla_vf_tx_rate *ivt = nla_data(tb[IFLA_VF_TX_RATE]);
|
||||
struct ifla_vf_info ivf;
|
||||
ivt = nla_data(vf);
|
||||
|
||||
err = -EOPNOTSUPP;
|
||||
if (ops->ndo_get_vf_config)
|
||||
err = ops->ndo_get_vf_config(dev, ivt->vf,
|
||||
&ivf);
|
||||
if (err)
|
||||
break;
|
||||
err = ops->ndo_get_vf_config(dev, ivt->vf, &ivf);
|
||||
if (err < 0)
|
||||
return err;
|
||||
|
||||
err = -EOPNOTSUPP;
|
||||
if (ops->ndo_set_vf_rate)
|
||||
err = ops->ndo_set_vf_rate(dev, ivt->vf,
|
||||
ivf.min_tx_rate,
|
||||
ivt->rate);
|
||||
break;
|
||||
if (err < 0)
|
||||
return err;
|
||||
}
|
||||
case IFLA_VF_RATE: {
|
||||
struct ifla_vf_rate *ivt;
|
||||
ivt = nla_data(vf);
|
||||
|
||||
if (tb[IFLA_VF_RATE]) {
|
||||
struct ifla_vf_rate *ivt = nla_data(tb[IFLA_VF_RATE]);
|
||||
|
||||
err = -EOPNOTSUPP;
|
||||
if (ops->ndo_set_vf_rate)
|
||||
err = ops->ndo_set_vf_rate(dev, ivt->vf,
|
||||
ivt->min_tx_rate,
|
||||
ivt->max_tx_rate);
|
||||
break;
|
||||
if (err < 0)
|
||||
return err;
|
||||
}
|
||||
case IFLA_VF_SPOOFCHK: {
|
||||
struct ifla_vf_spoofchk *ivs;
|
||||
ivs = nla_data(vf);
|
||||
|
||||
if (tb[IFLA_VF_SPOOFCHK]) {
|
||||
struct ifla_vf_spoofchk *ivs = nla_data(tb[IFLA_VF_SPOOFCHK]);
|
||||
|
||||
err = -EOPNOTSUPP;
|
||||
if (ops->ndo_set_vf_spoofchk)
|
||||
err = ops->ndo_set_vf_spoofchk(dev, ivs->vf,
|
||||
ivs->setting);
|
||||
break;
|
||||
if (err < 0)
|
||||
return err;
|
||||
}
|
||||
case IFLA_VF_LINK_STATE: {
|
||||
struct ifla_vf_link_state *ivl;
|
||||
ivl = nla_data(vf);
|
||||
|
||||
if (tb[IFLA_VF_LINK_STATE]) {
|
||||
struct ifla_vf_link_state *ivl = nla_data(tb[IFLA_VF_LINK_STATE]);
|
||||
|
||||
err = -EOPNOTSUPP;
|
||||
if (ops->ndo_set_vf_link_state)
|
||||
err = ops->ndo_set_vf_link_state(dev, ivl->vf,
|
||||
ivl->link_state);
|
||||
break;
|
||||
if (err < 0)
|
||||
return err;
|
||||
}
|
||||
case IFLA_VF_RSS_QUERY_EN: {
|
||||
|
||||
if (tb[IFLA_VF_RSS_QUERY_EN]) {
|
||||
struct ifla_vf_rss_query_en *ivrssq_en;
|
||||
|
||||
ivrssq_en = nla_data(vf);
|
||||
err = -EOPNOTSUPP;
|
||||
ivrssq_en = nla_data(tb[IFLA_VF_RSS_QUERY_EN]);
|
||||
if (ops->ndo_set_vf_rss_query_en)
|
||||
err = ops->ndo_set_vf_rss_query_en(dev,
|
||||
ivrssq_en->vf,
|
||||
err = ops->ndo_set_vf_rss_query_en(dev, ivrssq_en->vf,
|
||||
ivrssq_en->setting);
|
||||
break;
|
||||
}
|
||||
default:
|
||||
err = -EINVAL;
|
||||
break;
|
||||
}
|
||||
if (err)
|
||||
break;
|
||||
if (err < 0)
|
||||
return err;
|
||||
}
|
||||
|
||||
return err;
|
||||
}
|
||||
|
||||
|
@ -1773,14 +1771,21 @@ static int do_setlink(const struct sk_buff *skb,
|
|||
}
|
||||
|
||||
if (tb[IFLA_VFINFO_LIST]) {
|
||||
struct nlattr *vfinfo[IFLA_VF_MAX + 1];
|
||||
struct nlattr *attr;
|
||||
int rem;
|
||||
|
||||
nla_for_each_nested(attr, tb[IFLA_VFINFO_LIST], rem) {
|
||||
if (nla_type(attr) != IFLA_VF_INFO) {
|
||||
if (nla_type(attr) != IFLA_VF_INFO ||
|
||||
nla_len(attr) < NLA_HDRLEN) {
|
||||
err = -EINVAL;
|
||||
goto errout;
|
||||
}
|
||||
err = do_setvfinfo(dev, attr);
|
||||
err = nla_parse_nested(vfinfo, IFLA_VF_MAX, attr,
|
||||
ifla_vf_policy);
|
||||
if (err < 0)
|
||||
goto errout;
|
||||
err = do_setvfinfo(dev, vfinfo);
|
||||
if (err < 0)
|
||||
goto errout;
|
||||
status |= DO_SETLINK_NOTIFY;
|
||||
|
|
Loading…
Reference in New Issue