OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use WARN() in fs/ 

Use WARN() instead of a printk+WARN_ON() pair; this way the message
becomes part of the warning section for better reporting/collection.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Arjan van de Ven 2008-07-25 19:45:40 -07:00 committed by Linus Torvalds
parent 5cd2b459d3
commit 5c752ad9f3
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/buffer.c
View File

@ -1214,8 +1214,7 @@ void __brelse(struct buffer_head * buf)
put_bh(buf); put_bh(buf);
return; return;
} }
printk(KERN_ERR "VFS: brelse: Trying to free free buffer\n"); WARN(1, KERN_ERR "VFS: brelse: Trying to free free buffer\n");
WARN_ON(1);
} }
/* /*

3
fs/namespace.c
View File

@ -309,10 +309,9 @@ static void handle_write_count_underflow(struct vfsmount *mnt)
*/ */
if ((atomic_read(&mnt->__mnt_writers) < 0) && if ((atomic_read(&mnt->__mnt_writers) < 0) &&
!(mnt->mnt_flags & MNT_IMBALANCED_WRITE_COUNT)) { !(mnt->mnt_flags & MNT_IMBALANCED_WRITE_COUNT)) {
printk(KERN_DEBUG "leak detected on mount(%p) writers " WARN(1, KERN_DEBUG "leak detected on mount(%p) writers "
"count: %d\n", "count: %d\n",
mnt, atomic_read(&mnt->__mnt_writers)); mnt, atomic_read(&mnt->__mnt_writers));
WARN_ON(1);
/* use the flag to keep the dmesg spam down */ /* use the flag to keep the dmesg spam down */
mnt->mnt_flags |= MNT_IMBALANCED_WRITE_COUNT; mnt->mnt_flags |= MNT_IMBALANCED_WRITE_COUNT;
} }