mac80211: use unaligned safe memcmp() in-place of compare_ether_addr()
After fixing zd1211rw: use unaligned safe memcmp() in-place of compare_ether_addr(), I started to see kernel log messages detailing unaligned access: Kernel unaligned access at TPC[100f7f44] sta_info_get+0x24/0x68 [mac80211] As with the aforementioned patch, the unaligned access was eminating from a compare_ether_addr() call. Concerned that whilst it was safe to assume that unalignment was the norm for the zd1211rw, and take preventative measures, it may not be the case or acceptable to use the easy fix of changing the call to memcmp(). My research however indicated that it was OK to do this, as there are a few instances where memcmp() is the preferred mechanism for doing mac address comparisons throughout the module. Signed-off-by: Shaddy Baddah <shaddy_baddah@hotmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
b8ddafd759
commit
5cf12e8dc6
|
@ -99,7 +99,7 @@ struct sta_info *sta_info_get(struct ieee80211_local *local, const u8 *addr)
|
||||||
|
|
||||||
sta = rcu_dereference(local->sta_hash[STA_HASH(addr)]);
|
sta = rcu_dereference(local->sta_hash[STA_HASH(addr)]);
|
||||||
while (sta) {
|
while (sta) {
|
||||||
if (compare_ether_addr(sta->sta.addr, addr) == 0)
|
if (memcmp(sta->sta.addr, addr, ETH_ALEN) == 0)
|
||||||
break;
|
break;
|
||||||
sta = rcu_dereference(sta->hnext);
|
sta = rcu_dereference(sta->hnext);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue