OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

media: dvb_core: slight optimization of addr compare 

Use possibly more efficient ether_addr_equal
instead of memcmp.

Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
dingtianhong 2013-12-26 19:41:10 +08:00 committed by David S. Miller
parent 48f045b911
commit 5e231c2c5a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/dvb-core/dvb_net.c
View File

@ -179,7 +179,7 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *skb,
eth = eth_hdr(skb); eth = eth_hdr(skb);
if (*eth->h_dest & 1) { if (*eth->h_dest & 1) {
if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0) if(ether_addr_equal(eth->h_dest,dev->broadcast))
skb->pkt_type=PACKET_BROADCAST; skb->pkt_type=PACKET_BROADCAST;
else else
skb->pkt_type=PACKET_MULTICAST; skb->pkt_type=PACKET_MULTICAST;
@ -674,11 +674,13 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len )
if (priv->rx_mode != RX_MODE_PROMISC) { if (priv->rx_mode != RX_MODE_PROMISC) {
if (priv->ule_skb->data[0] & 0x01) { if (priv->ule_skb->data[0] & 0x01) {
/* multicast or broadcast */ /* multicast or broadcast */
if (memcmp(priv->ule_skb->data, bc_addr, ETH_ALEN)) { if (!ether_addr_equal(priv->ule_skb->data, bc_addr)) {
/* multicast */ /* multicast */
if (priv->rx_mode == RX_MODE_MULTI) { if (priv->rx_mode == RX_MODE_MULTI) {
int i; int i;
for(i = 0; i < priv->multi_num && memcmp(priv->ule_skb->data, priv->multi_macs[i], ETH_ALEN); i++) for(i = 0; i < priv->multi_num &&
!ether_addr_equal(priv->ule_skb->data,
priv->multi_macs[i]); i++)
; ;
if (i == priv->multi_num) if (i == priv->multi_num)
drop = 1; drop = 1;
@ -688,7 +690,7 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len )
} }
/* else: broadcast */ /* else: broadcast */
} }
else if (memcmp(priv->ule_skb->data, dev->dev_addr, ETH_ALEN)) else if (!ether_addr_equal(priv->ule_skb->data, dev->dev_addr))
drop = 1; drop = 1;
/* else: destination address matches the MAC address of our receiver device */ /* else: destination address matches the MAC address of our receiver device */
} }