OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cxgb4vf: make single bit signed bitfields unsigned 

Single bit signed bitfields don't make a lot of sense, noticed by sparse:
drivers/net/cxgb4vf/t4vf_common.h:135:31: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:136:36: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:137:36: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:138:36: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:139:36: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:140:31: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:141:31: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:142:35: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:143:35: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:154:27: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:155:26: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:156:27: error: dubious one-bit signed bitfield
drivers/net/cxgb4vf/t4vf_common.h:157:26: error: dubious one-bit signed bitfield

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Harvey Harrison 2010-10-12 21:52:26 +00:00 committed by David S. Miller
parent 564824b0c5
commit 65495745d7
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/net/cxgb4vf/t4vf_common.h
View File

@ -132,15 +132,15 @@ struct rss_params {
unsigned int mode; /* RSS mode */
union {
struct {
int synmapen:1; /* SYN Map Enable */
int syn4tupenipv6:1; /* enable hashing 4-tuple IPv6 SYNs */
int syn2tupenipv6:1; /* enable hashing 2-tuple IPv6 SYNs */
int syn4tupenipv4:1; /* enable hashing 4-tuple IPv4 SYNs */
int syn2tupenipv4:1; /* enable hashing 2-tuple IPv4 SYNs */
int ofdmapen:1; /* Offload Map Enable */
int tnlmapen:1; /* Tunnel Map Enable */
int tnlalllookup:1; /* Tunnel All Lookup */
int hashtoeplitz:1; /* use Toeplitz hash */
unsigned int synmapen:1; /* SYN Map Enable */
unsigned int syn4tupenipv6:1; /* enable hashing 4-tuple IPv6 SYNs */
unsigned int syn2tupenipv6:1; /* enable hashing 2-tuple IPv6 SYNs */
unsigned int syn4tupenipv4:1; /* enable hashing 4-tuple IPv4 SYNs */
unsigned int syn2tupenipv4:1; /* enable hashing 2-tuple IPv4 SYNs */
unsigned int ofdmapen:1; /* Offload Map Enable */
unsigned int tnlmapen:1; /* Tunnel Map Enable */
unsigned int tnlalllookup:1; /* Tunnel All Lookup */
unsigned int hashtoeplitz:1; /* use Toeplitz hash */
} basicvirtual;
} u;
};
@ -151,10 +151,10 @@ struct rss_params {
union rss_vi_config {
struct {
u16 defaultq; /* Ingress Queue ID for !tnlalllookup */
int ip6fourtupen:1; /* hash 4-tuple IPv6 ingress packets */
int ip6twotupen:1; /* hash 2-tuple IPv6 ingress packets */
int ip4fourtupen:1; /* hash 4-tuple IPv4 ingress packets */
int ip4twotupen:1; /* hash 2-tuple IPv4 ingress packets */
unsigned int ip6fourtupen:1; /* hash 4-tuple IPv6 ingress packets */
unsigned int ip6twotupen:1; /* hash 2-tuple IPv6 ingress packets */
unsigned int ip4fourtupen:1; /* hash 4-tuple IPv4 ingress packets */
unsigned int ip4twotupen:1; /* hash 2-tuple IPv4 ingress packets */
int udpen; /* hash 4-tuple UDP ingress packets */
} basicvirtual;
};