OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

padata: get_next is never NULL 

Per Dan's static checker warning, the code that returns NULL was removed
in 2010, so this patch updates the comments and fixes the code
assumptions.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Jason A. Donenfeld 2017-04-12 10:40:19 +02:00 committed by Herbert Xu
parent c46ea13f55
commit 69b348449b
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
kernel/padata.c
View File

@ -154,8 +154,6 @@ EXPORT_SYMBOL(padata_do_parallel);
* A pointer to the control struct of the next object that needs * A pointer to the control struct of the next object that needs
* serialization, if present in one of the percpu reorder queues. * serialization, if present in one of the percpu reorder queues.
* *
* NULL, if all percpu reorder queues are empty.
*
* -EINPROGRESS, if the next object that needs serialization will * -EINPROGRESS, if the next object that needs serialization will
* be parallel processed by another cpu and is not yet present in * be parallel processed by another cpu and is not yet present in
* the cpu's reorder queue. * the cpu's reorder queue.
@ -182,8 +180,6 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
cpu = padata_index_to_cpu(pd, next_index); cpu = padata_index_to_cpu(pd, next_index);
next_queue = per_cpu_ptr(pd->pqueue, cpu); next_queue = per_cpu_ptr(pd->pqueue, cpu);
padata = NULL;
reorder = &next_queue->reorder; reorder = &next_queue->reorder;
spin_lock(&reorder->lock); spin_lock(&reorder->lock);
@ -235,12 +231,11 @@ static void padata_reorder(struct parallel_data *pd)
padata = padata_get_next(pd); padata = padata_get_next(pd);
/* /*
* All reorder queues are empty, or the next object that needs * If the next object that needs serialization is parallel
* serialization is parallel processed by another cpu and is * processed by another cpu and is still on it's way to the
* still on it's way to the cpu's reorder queue, nothing to * cpu's reorder queue, nothing to do for now.
* do for now.
*/ */
if (!padata || PTR_ERR(padata) == -EINPROGRESS) if (PTR_ERR(padata) == -EINPROGRESS)
break; break;
/* /*