ieee1394: Fix kthread stopping in nodemgr_host_thread
The nodemgr host thread can exit on its own even when kthread_should_stop is not true, on receiving a signal (might never happen in practice, as it ignores signals). But considering kthread_stop() must not be mixed with kthreads that can exit on their own, I think changing the code like this is clearer. This change means the thread can cut its sleep short when receive a signal but looking at the code around, that sounds okay (and again, it might never actually recieve a signal in practice). Signed-off-by: Satyam Sharma <satyam@infradead.org> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
parent
261b5f664c
commit
69e2b60296
|
@ -1712,7 +1712,8 @@ static int nodemgr_host_thread(void *__hi)
|
|||
* to make sure things settle down. */
|
||||
g = get_hpsb_generation(host);
|
||||
for (i = 0; i < 4 ; i++) {
|
||||
if (msleep_interruptible(63) || kthread_should_stop())
|
||||
msleep_interruptible(63);
|
||||
if (kthread_should_stop())
|
||||
goto exit;
|
||||
|
||||
/* Now get the generation in which the node ID's we collect
|
||||
|
|
Loading…
Reference in New Issue