[XFS] Fix lock inversion in forced shutdown.
Recent changes to xlog_state_release_iclog() placed the grant_lock inside the icloglock. forced unmount of the log does this the opposite way around, but does not depend on the order for correct working. Fix the inversion by changing the order locks are gained in xfs_log_force_umount(). SGI-PV: 979661 SGI-Modid: xfs-linux-melb:xfs-kern:30773a Signed-off-by: David Chinner <dgc@sgi.com> Signed-off-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
This commit is contained in:
parent
4679b2d36d
commit
6b1d1a732f
|
@ -3499,8 +3499,8 @@ xfs_log_force_umount(
|
|||
* before we mark the filesystem SHUTDOWN and wake
|
||||
* everybody up to tell the bad news.
|
||||
*/
|
||||
spin_lock(&log->l_grant_lock);
|
||||
spin_lock(&log->l_icloglock);
|
||||
spin_lock(&log->l_grant_lock);
|
||||
mp->m_flags |= XFS_MOUNT_FS_SHUTDOWN;
|
||||
XFS_BUF_DONE(mp->m_sb_bp);
|
||||
/*
|
||||
|
|
Loading…
Reference in New Issue