[PATCH] Dereference in tokenring/olympic.c
hi, coverity found (bug id #225) that we might call free_netdev() with NULL argument, when alloc_trdev() fails. This patch changes the goto, so we dont call free_netdev() for dev == NULL. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
parent
a192491ad5
commit
6d56ab9362
|
@ -217,7 +217,7 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device
|
||||||
dev = alloc_trdev(sizeof(struct olympic_private)) ;
|
dev = alloc_trdev(sizeof(struct olympic_private)) ;
|
||||||
if (!dev) {
|
if (!dev) {
|
||||||
i = -ENOMEM;
|
i = -ENOMEM;
|
||||||
goto op_free_dev;
|
goto op_release_dev;
|
||||||
}
|
}
|
||||||
|
|
||||||
olympic_priv = dev->priv ;
|
olympic_priv = dev->priv ;
|
||||||
|
@ -282,8 +282,8 @@ op_free_iomap:
|
||||||
if (olympic_priv->olympic_lap)
|
if (olympic_priv->olympic_lap)
|
||||||
iounmap(olympic_priv->olympic_lap);
|
iounmap(olympic_priv->olympic_lap);
|
||||||
|
|
||||||
op_free_dev:
|
|
||||||
free_netdev(dev);
|
free_netdev(dev);
|
||||||
|
op_release_dev:
|
||||||
pci_release_regions(pdev);
|
pci_release_regions(pdev);
|
||||||
|
|
||||||
op_disable_dev:
|
op_disable_dev:
|
||||||
|
|
Loading…
Reference in New Issue