scsi: st: Fix a use after free in st_open()
[ Upstream commit c8c165dea4c8f5ad67b1240861e4f6c5395fa4ac ] In st_open(), if STp->in_use is true, STp will be freed by scsi_tape_put(). However, STp is still used by DEBC_printk() after. It is better to DEBC_printk() before scsi_tape_put(). Link: https://lore.kernel.org/r/20210311064636.10522-1-lyl2019@mail.ustc.edu.cn Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
98052c40e3
commit
6e79f829e7
|
@ -1267,8 +1267,8 @@ static int st_open(struct inode *inode, struct file *filp)
|
||||||
spin_lock(&st_use_lock);
|
spin_lock(&st_use_lock);
|
||||||
if (STp->in_use) {
|
if (STp->in_use) {
|
||||||
spin_unlock(&st_use_lock);
|
spin_unlock(&st_use_lock);
|
||||||
scsi_tape_put(STp);
|
|
||||||
DEBC_printk(STp, "Device already in use.\n");
|
DEBC_printk(STp, "Device already in use.\n");
|
||||||
|
scsi_tape_put(STp);
|
||||||
return (-EBUSY);
|
return (-EBUSY);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue