Thermal: Check for validity before doing kfree
The thermal_release function is called whenever any device belonging to 'thermal' class unregisters. This function performs kfree(cdev) without any check. In cases where there are more device registrations other than just 'thermal_zone' and 'cooling_device' this might accidently free memory allocated them silently; and cause memory errors. This patch changes this behavior by doing kfree(cdev) only when the device pointer belongs to a real cdev i.e. cooling_device. Signed-off-by: Durgadoss R <durgadoss.r@intel.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
This commit is contained in:
parent
a822794886
commit
732e4c8db9
|
@ -1038,7 +1038,8 @@ static void thermal_release(struct device *dev)
|
||||||
sizeof("thermal_zone") - 1)) {
|
sizeof("thermal_zone") - 1)) {
|
||||||
tz = to_thermal_zone(dev);
|
tz = to_thermal_zone(dev);
|
||||||
kfree(tz);
|
kfree(tz);
|
||||||
} else {
|
} else if(!strncmp(dev_name(dev), "cooling_device",
|
||||||
|
sizeof("cooling_device") - 1)){
|
||||||
cdev = to_cooling_device(dev);
|
cdev = to_cooling_device(dev);
|
||||||
kfree(cdev);
|
kfree(cdev);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue