ftrace: force pass of preemptoff selftest
Impact: preemptoff not tested in selftest Due to the BKL not being preemptable anymore, the selftest of the preemptoff code can not be tested. It requires that it is called with preemption enabled, but since the BKL is held, that is no longer the case. This patch simply skips those tests if it detects that the context is not preemptable. The following will now show up in the tests: Testing tracer preemptoff: can not test ... force PASSED Testing tracer preemptirqsoff: can not test ... force PASSED When the BKL is removed, or it becomes preemptable once again, then the tests will be performed. Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
parent
7d5222a6af
commit
769c48eb25
|
@ -257,6 +257,19 @@ trace_selftest_startup_preemptoff(struct tracer *trace, struct trace_array *tr)
|
|||
unsigned long count;
|
||||
int ret;
|
||||
|
||||
/*
|
||||
* Now that the big kernel lock is no longer preemptable,
|
||||
* and this is called with the BKL held, it will always
|
||||
* fail. If preemption is already disabled, simply
|
||||
* pass the test. When the BKL is removed, or becomes
|
||||
* preemptible again, we will once again test this,
|
||||
* so keep it in.
|
||||
*/
|
||||
if (preempt_count()) {
|
||||
printk(KERN_CONT "can not test ... force ");
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* start the tracing */
|
||||
trace->init(tr);
|
||||
/* reset the max latency */
|
||||
|
@ -293,6 +306,19 @@ trace_selftest_startup_preemptirqsoff(struct tracer *trace, struct trace_array *
|
|||
unsigned long count;
|
||||
int ret;
|
||||
|
||||
/*
|
||||
* Now that the big kernel lock is no longer preemptable,
|
||||
* and this is called with the BKL held, it will always
|
||||
* fail. If preemption is already disabled, simply
|
||||
* pass the test. When the BKL is removed, or becomes
|
||||
* preemptible again, we will once again test this,
|
||||
* so keep it in.
|
||||
*/
|
||||
if (preempt_count()) {
|
||||
printk(KERN_CONT "can not test ... force ");
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* start the tracing */
|
||||
trace->init(tr);
|
||||
|
||||
|
|
Loading…
Reference in New Issue