pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call
commit5ff8aca906
upstream. The call to pinctrl_count_index_with_args checks for a -EINVAL return however this function calls pinctrl_get_list_and_count and this can return -ENOENT. Rather than check for a specific error, fix this by checking for any error return to catch the -ENOENT case. Addresses-Coverity: ("Improper use of negative") Fixes:003910ebc8
("pinctrl: Introduce TI IOdelay configuration driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20190920122030.14340-1-colin.king@canonical.com Acked-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
6bdc0eab88
commit
7d37e27a8a
|
@ -496,7 +496,7 @@ static int ti_iodelay_dt_node_to_map(struct pinctrl_dev *pctldev,
|
|||
return -EINVAL;
|
||||
|
||||
rows = pinctrl_count_index_with_args(np, name);
|
||||
if (rows == -EINVAL)
|
||||
if (rows < 0)
|
||||
return rows;
|
||||
|
||||
*map = devm_kzalloc(iod->dev, sizeof(**map), GFP_KERNEL);
|
||||
|
|
Loading…
Reference in New Issue