OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: sierra: fix memory leak in attach error path 

Make sure port private data is deallocated on errors in attach.

Cc: <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2012-10-25 10:29:17 +02:00 committed by Greg Kroah-Hartman
parent b8f0e82044
commit 7e41f9bcdd
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/serial/sierra.c
View File

@ -905,7 +905,7 @@ static int sierra_startup(struct usb_serial *serial)
dev_dbg(&port->dev, "%s: kmalloc for "
"sierra_port_private (%d) failed!\n",
__func__, i);
return -ENOMEM;
goto err;
}
spin_lock_init(&portdata->lock);
init_usb_anchor(&portdata->active);
@ -942,6 +942,13 @@ static int sierra_startup(struct usb_serial *serial)
}
return 0;
err:
for (--i; i >= 0; --i) {
portdata = usb_get_serial_port_data(serial->port[i]);
kfree(portdata);
}
return -ENOMEM;
}
static void sierra_release(struct usb_serial *serial)