OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mfd: sec-core: Return gracefully instead of BUG() if device cannot match 

Replace impossible BUG() in probe with a proper return.  This can be
triggered only in case of a clear bug (e.g. adding broken half-support
for new S2MPSXX flavor) but BUG() is discouraged and the boot process
can actually try to continue.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Krzysztof Kozlowski 2019-01-29 12:25:53 +01:00 committed by Lee Jones
parent 9f208eca4f
commit 83761f9663
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mfd/sec-core.c
View File

@ -471,8 +471,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
num_sec_devs = ARRAY_SIZE(s2mpu02_devs); num_sec_devs = ARRAY_SIZE(s2mpu02_devs);
break; break;
default: default:
/* If this happens the probe function is problem */ dev_err(&i2c->dev, "Unsupported device type (%lu)\n",
BUG(); sec_pmic->device_type);
return -ENODEV;
} }
ret = devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, ret = devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs,
NULL, 0, NULL); NULL, 0, NULL);