rtc: pcf2123: Add missing error code assignment before test
It is likely that checking the result of 'pcf2123_write_reg' is expected
here.
Also fix a small style issue. The '{' at the beginning of the function
is misplaced.
Fixes: 809b453b76
("rtc: pcf2123: clean up writes to the rtc chip")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
This commit is contained in:
parent
04940631b8
commit
83ab7dad06
|
@ -182,7 +182,8 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr,
|
||||||
}
|
}
|
||||||
|
|
||||||
static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
|
static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
|
||||||
const char *buffer, size_t count) {
|
const char *buffer, size_t count)
|
||||||
|
{
|
||||||
struct pcf2123_sysfs_reg *r;
|
struct pcf2123_sysfs_reg *r;
|
||||||
unsigned long reg;
|
unsigned long reg;
|
||||||
unsigned long val;
|
unsigned long val;
|
||||||
|
@ -199,7 +200,7 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
|
||||||
if (ret)
|
if (ret)
|
||||||
return ret;
|
return ret;
|
||||||
|
|
||||||
pcf2123_write_reg(dev, reg, val);
|
ret = pcf2123_write_reg(dev, reg, val);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
return -EIO;
|
return -EIO;
|
||||||
return count;
|
return count;
|
||||||
|
|
Loading…
Reference in New Issue