OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

virtchnl: Fix off by one error 

When calculating the valid length for a VIRTCHNL_OP_ENABLE_CHANNELS
message, we accidentally allowed messages with one extra
virtchnl_channel_info structure on the end. This happened due
to an off by one error, because we forgot that valid_len already
accounted for one virtchnl_channel_info structure, so we need to
subtract one from the num_tc value.

Signed-off-by: Alice Michael <alice.michael@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Alice Michael 2018-10-26 14:33:31 -07:00 committed by Jeff Kirsher
parent c9a983058a
commit 843faff87a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/avf/virtchnl.h
View File

@ -819,8 +819,8 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,
if (msglen >= valid_len) { if (msglen >= valid_len) {
struct virtchnl_tc_info *vti = struct virtchnl_tc_info *vti =
(struct virtchnl_tc_info *)msg; (struct virtchnl_tc_info *)msg;
valid_len += vti->num_tc * valid_len += (vti->num_tc - 1) *
sizeof(struct virtchnl_channel_info); sizeof(struct virtchnl_channel_info);
if (vti->num_tc == 0) if (vti->num_tc == 0)
err_msg_format = true; err_msg_format = true;
} }