OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hwmon: (it87) Fix fan tachometer reading in IT8712F rev 0x7 (I) 

The IT8712F v0.9.1 datasheet applies to revisions >= 0x8 (J).
The driver was incorrectly attempting to enable 16-bit fan
readings on rev 0x7 (I) which led to incorrect RPM values.

Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
Tested-by: John Gumb <john.gumb@tandberg.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
This commit is contained in:
Andrew Paprocki 2008-09-20 10:25:19 +02:00 committed by Jean Delvare
parent 13b3c3fa27
commit 859b9ef30c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hwmon/it87.c
View File

@ -273,10 +273,10 @@ struct it87_data {
static inline int has_16bit_fans(const struct it87_data *data) static inline int has_16bit_fans(const struct it87_data *data)
{ {
/* IT8705F Datasheet 0.4.1, 3h == Version G. /* IT8705F Datasheet 0.4.1, 3h == Version G.
IT8712F Datasheet 0.9.1, section 8.3.5 indicates 7h == Version I. IT8712F Datasheet 0.9.1, section 8.3.5 indicates 8h == Version J.
These are the first revisions with 16bit tachometer support. */ These are the first revisions with 16bit tachometer support. */
return (data->type == it87 && data->revision >= 0x03) return (data->type == it87 && data->revision >= 0x03)
|| (data->type == it8712 && data->revision >= 0x07) || (data->type == it8712 && data->revision >= 0x08)
|| data->type == it8716 || data->type == it8716
|| data->type == it8718; || data->type == it8718;
} }