ieee1394: ohci1394: don't schedule IT tasklets on IR events
Bug noted by Pieter Palmers: Isochronous transmit tasklets were scheduled on isochronous receive events, in addition to the proper isochronous receive tasklets. http://marc.info/?l=linux1394-devel&m=119783196222802 Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
parent
4e6343a10b
commit
85c5798b09
|
@ -2126,11 +2126,15 @@ static void ohci_schedule_iso_tasklets(struct ti_ohci *ohci,
|
||||||
list_for_each_entry(t, &ohci->iso_tasklet_list, link) {
|
list_for_each_entry(t, &ohci->iso_tasklet_list, link) {
|
||||||
mask = 1 << t->context;
|
mask = 1 << t->context;
|
||||||
|
|
||||||
if (t->type == OHCI_ISO_TRANSMIT && tx_event & mask)
|
if (t->type == OHCI_ISO_TRANSMIT) {
|
||||||
|
if (tx_event & mask)
|
||||||
tasklet_schedule(&t->tasklet);
|
tasklet_schedule(&t->tasklet);
|
||||||
else if (rx_event & mask)
|
} else {
|
||||||
|
/* OHCI_ISO_RECEIVE or OHCI_ISO_MULTICHANNEL_RECEIVE */
|
||||||
|
if (rx_event & mask)
|
||||||
tasklet_schedule(&t->tasklet);
|
tasklet_schedule(&t->tasklet);
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
spin_unlock_irqrestore(&ohci->iso_tasklet_list_lock, flags);
|
spin_unlock_irqrestore(&ohci->iso_tasklet_list_lock, flags);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue