staging/rts5208: Fix read overflow in memcpy
Noticed by FORTIFY_SOURCE, this swaps memcpy() for strncpy() to zero-value fill the end of the buffer instead of over-reading a string from .rodata. Signed-off-by: Daniel Micay <danielmicay@gmail.com> [kees: wrote commit log] Signed-off-by: Kees Cook <keescook@chromium.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
372bd1eb84
commit
88a5b39b69
|
@ -536,7 +536,7 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
|
||||||
|
|
||||||
if (sendbytes > 8) {
|
if (sendbytes > 8) {
|
||||||
memcpy(buf, inquiry_buf, 8);
|
memcpy(buf, inquiry_buf, 8);
|
||||||
memcpy(buf + 8, inquiry_string, sendbytes - 8);
|
strncpy(buf + 8, inquiry_string, sendbytes - 8);
|
||||||
if (pro_formatter_flag) {
|
if (pro_formatter_flag) {
|
||||||
/* Additional Length */
|
/* Additional Length */
|
||||||
buf[4] = 0x33;
|
buf[4] = 0x33;
|
||||||
|
|
Loading…
Reference in New Issue