OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Staging: heci: do not print error when heci_bh_handler is already on workqueue 

schedule_work returns 0, if the work is already on the work_queue, else
returns non-zero. Do not print error message if heci_bh_handlerwork was
already on queue.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Dongxiao Xu 2009-05-31 14:43:58 +08:00 committed by Greg Kroah-Hartman
parent ad914a3ec5
commit 8d1c50e982
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/heci/interrupt.c
View File

@ -103,10 +103,8 @@ irqreturn_t heci_isr_interrupt(int irq, void *dev_id)
PREPARE_WORK(&dev->work, heci_bh_handler);
DBG("schedule work the heci_bh_handler.\n");
err = schedule_work(&dev->work);
if (!err) {
printk(KERN_ERR "heci: schedule the heci_bh_handler"
" failed error=%x\n", err);
}
if (!err)
DBG("heci_bh_handler was already on the workqueue.\n");
return IRQ_HANDLED;
}
@ -260,10 +258,8 @@ end:
PREPARE_WORK(&dev->work, heci_bh_handler);
DBG("schedule work the heci_bh_handler.\n");
rets = schedule_work(&dev->work);
if (!rets) {
printk(KERN_ERR "heci: schedule the heci_bh_handler"
" failed error=%x\n", rets);
}
if (!rets)
DBG("heci_bh_handler was already queued.\n");
} else {
heci_csr_enable_interrupts(dev);
}