OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drm/panfrost: Add a module parameter to expose unstable ioctls

Browse Source 
We plan to expose performance counters through 2 driver specific
ioctls until there's a solution to expose them in a generic way.
In order to be able to deprecate those ioctls when this new
infrastructure is in place we add an unsafe module parameter that
will keep those ioctls hidden unless it's set to true (which also
has the effect of tainting the kernel).

All unstable ioctl handlers should use panfrost_unstable_ioctl_check()
to check whether they're supposed to handle the request or reject it
with ENOSYS.

Suggested-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190618081648.17297-3-boris.brezillon@collabora.com
This commit is contained in:
Boris Brezillon 2019-06-18 10:16:46 +02:00 committed by Rob Herring
parent dd082cef99
commit 92f0ad0b1d
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/panfrost/panfrost_device.h
View File

@ -115,6 +115,8 @@ static inline bool panfrost_model_eq(struct panfrost_device *pfdev, s32 id)
return !panfrost_model_cmp(pfdev, id); return !panfrost_model_cmp(pfdev, id);
} }
int panfrost_unstable_ioctl_check(void);
int panfrost_device_init(struct panfrost_device *pfdev); int panfrost_device_init(struct panfrost_device *pfdev);
void panfrost_device_fini(struct panfrost_device *pfdev); void panfrost_device_fini(struct panfrost_device *pfdev);

11
drivers/gpu/drm/panfrost/panfrost_drv.c
View File

@ -20,6 +20,9 @@
#include "panfrost_job.h" #include "panfrost_job.h"
#include "panfrost_gpu.h" #include "panfrost_gpu.h"
static bool unstable_ioctls;
module_param_unsafe(unstable_ioctls, bool, 0600);
static int panfrost_ioctl_get_param(struct drm_device *ddev, void *data, struct drm_file *file) static int panfrost_ioctl_get_param(struct drm_device *ddev, void *data, struct drm_file *file)
{ {
struct drm_panfrost_get_param *param = data; struct drm_panfrost_get_param *param = data;
@ -297,6 +300,14 @@ static int panfrost_ioctl_get_bo_offset(struct drm_device *dev, void *data,
return 0; return 0;
} }
int panfrost_unstable_ioctl_check(void)
{
if (!unstable_ioctls)
return -ENOSYS;
return 0;
}
static int static int
panfrost_open(struct drm_device *dev, struct drm_file *file) panfrost_open(struct drm_device *dev, struct drm_file *file)
{ {