backlight: atmel-pwm-bl: use gpio_request_one
Use devm_gpio_request_one rather than requesting and setting direction in two calls. Signed-off-by: Johan Hovold <jhovold@gmail.com> Cc: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
81b62db56d
commit
9b3521ee8f
|
@ -124,6 +124,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
|
||||||
const struct atmel_pwm_bl_platform_data *pdata;
|
const struct atmel_pwm_bl_platform_data *pdata;
|
||||||
struct backlight_device *bldev;
|
struct backlight_device *bldev;
|
||||||
struct atmel_pwm_bl *pwmbl;
|
struct atmel_pwm_bl *pwmbl;
|
||||||
|
unsigned long flags;
|
||||||
int retval;
|
int retval;
|
||||||
|
|
||||||
pdata = dev_get_platdata(&pdev->dev);
|
pdata = dev_get_platdata(&pdev->dev);
|
||||||
|
@ -149,14 +150,14 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
|
||||||
return retval;
|
return retval;
|
||||||
|
|
||||||
if (gpio_is_valid(pwmbl->gpio_on)) {
|
if (gpio_is_valid(pwmbl->gpio_on)) {
|
||||||
retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on,
|
|
||||||
"gpio_atmel_pwm_bl");
|
|
||||||
if (retval)
|
|
||||||
goto err_free_pwm;
|
|
||||||
|
|
||||||
/* Turn display off by default. */
|
/* Turn display off by default. */
|
||||||
retval = gpio_direction_output(pwmbl->gpio_on,
|
if (pdata->on_active_low)
|
||||||
0 ^ pdata->on_active_low);
|
flags = GPIOF_OUT_INIT_HIGH;
|
||||||
|
else
|
||||||
|
flags = GPIOF_OUT_INIT_LOW;
|
||||||
|
|
||||||
|
retval = devm_gpio_request_one(&pdev->dev, pwmbl->gpio_on,
|
||||||
|
flags, "gpio_atmel_pwm_bl");
|
||||||
if (retval)
|
if (retval)
|
||||||
goto err_free_pwm;
|
goto err_free_pwm;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue