[PATCH] nfsd: sign conversion obscuring errors in nfsd_set_posix_acl()
Assigning the result of posix_acl_to_xattr() to an unsigned data type (size/size_t) obscures possible errors. Coverity CID: 1206. Signed-off-by: Florin Malita <fmalita@gmail.com> Acked-by: NeilBrown <neilb@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
2adc7d47c4
commit
9ccfc29c67
|
@ -1922,11 +1922,10 @@ nfsd_set_posix_acl(struct svc_fh *fhp, int type, struct posix_acl *acl)
|
|||
value = kmalloc(size, GFP_KERNEL);
|
||||
if (!value)
|
||||
return -ENOMEM;
|
||||
size = posix_acl_to_xattr(acl, value, size);
|
||||
if (size < 0) {
|
||||
error = size;
|
||||
error = posix_acl_to_xattr(acl, value, size);
|
||||
if (error < 0)
|
||||
goto getout;
|
||||
}
|
||||
size = error;
|
||||
} else
|
||||
size = 0;
|
||||
|
||||
|
|
Loading…
Reference in New Issue