drivers/misc/sgi-gru: add return on error
If the buffer is too small then return the error and in the process remove the variables which became unused. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Dimitri Sivanich <sivanich@sgi.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
bf84b1406c
commit
a010d27617
|
@ -78,11 +78,10 @@ static int gru_dump_tfm(struct gru_state *gru,
|
|||
void __user *ubuf, void __user *ubufend)
|
||||
{
|
||||
struct gru_tlb_fault_map *tfm;
|
||||
int i, ret, bytes;
|
||||
int i;
|
||||
|
||||
bytes = GRU_NUM_TFM * GRU_CACHE_LINE_BYTES;
|
||||
if (bytes > ubufend - ubuf)
|
||||
ret = -EFBIG;
|
||||
if (GRU_NUM_TFM * GRU_CACHE_LINE_BYTES > ubufend - ubuf)
|
||||
return -EFBIG;
|
||||
|
||||
for (i = 0; i < GRU_NUM_TFM; i++) {
|
||||
tfm = get_tfm(gru->gs_gru_base_vaddr, i);
|
||||
|
@ -99,11 +98,10 @@ static int gru_dump_tgh(struct gru_state *gru,
|
|||
void __user *ubuf, void __user *ubufend)
|
||||
{
|
||||
struct gru_tlb_global_handle *tgh;
|
||||
int i, ret, bytes;
|
||||
int i;
|
||||
|
||||
bytes = GRU_NUM_TGH * GRU_CACHE_LINE_BYTES;
|
||||
if (bytes > ubufend - ubuf)
|
||||
ret = -EFBIG;
|
||||
if (GRU_NUM_TGH * GRU_CACHE_LINE_BYTES > ubufend - ubuf)
|
||||
return -EFBIG;
|
||||
|
||||
for (i = 0; i < GRU_NUM_TGH; i++) {
|
||||
tgh = get_tgh(gru->gs_gru_base_vaddr, i);
|
||||
|
|
Loading…
Reference in New Issue