media: s5p-mfc: Fix a reference count leak
[ Upstream commit78741ce98c
] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes:c5086f130a
("[media] s5p-mfc: Use clock gating only on MFC v5 hardware") Signed-off-by: Qiushi Wu <wu000273@umn.edu> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
0747ff17aa
commit
a05590cc08
|
@ -79,8 +79,10 @@ int s5p_mfc_power_on(void)
|
|||
int i, ret = 0;
|
||||
|
||||
ret = pm_runtime_get_sync(pm->device);
|
||||
if (ret < 0)
|
||||
if (ret < 0) {
|
||||
pm_runtime_put_noidle(pm->device);
|
||||
return ret;
|
||||
}
|
||||
|
||||
/* clock control */
|
||||
for (i = 0; i < pm->num_clocks; i++) {
|
||||
|
|
Loading…
Reference in New Issue