drm/mgag200: do not attempt to acquire a reservation while in an interrupt handler
Mutexes should not be acquired in interrupt context. While the trylock fastpath is arguably safe on all implementations, the slowpath unlock path definitely isn't. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
parent
19d4b72c0c
commit
a06b9a74c7
|
@ -27,7 +27,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev,
|
||||||
struct mgag200_bo *bo;
|
struct mgag200_bo *bo;
|
||||||
int src_offset, dst_offset;
|
int src_offset, dst_offset;
|
||||||
int bpp = (mfbdev->mfb.base.bits_per_pixel + 7)/8;
|
int bpp = (mfbdev->mfb.base.bits_per_pixel + 7)/8;
|
||||||
int ret;
|
int ret = -EBUSY;
|
||||||
bool unmap = false;
|
bool unmap = false;
|
||||||
bool store_for_later = false;
|
bool store_for_later = false;
|
||||||
int x2, y2;
|
int x2, y2;
|
||||||
|
@ -41,7 +41,8 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev,
|
||||||
* then the BO is being moved and we should
|
* then the BO is being moved and we should
|
||||||
* store up the damage until later.
|
* store up the damage until later.
|
||||||
*/
|
*/
|
||||||
ret = mgag200_bo_reserve(bo, true);
|
if (!in_interrupt())
|
||||||
|
ret = mgag200_bo_reserve(bo, true);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
if (ret != -EBUSY)
|
if (ret != -EBUSY)
|
||||||
return;
|
return;
|
||||||
|
|
Loading…
Reference in New Issue