OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: rtlwifi: Reviewers fixes 

This commit adds the TODO file and implements some reviewers comments
made against some patches to the wireless tree.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Cc: Birming Chiu <birming@realtek.com>
Cc: Shaofu <shaofu@realtek.com>
Cc: Steven Ting <steventing@realtek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Larry Finger 2017-08-17 12:46:52 -05:00 committed by Greg Kroah-Hartman
parent 5b5ab4cb5c
commit a575de2da5
4 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/rtlwifi/TODO
View File

@ -1,11 +1,11 @@
TODO: TODO:
- checkpatch.pl fixes - most of the remaining ones are lines too long. Many
of them will require refactoring
- merge Realtek's bugfixes and new features into the driver
- find and remove code blocks guarded by never set CONFIG_FOO defines - find and remove code blocks guarded by never set CONFIG_FOO defines
- convert any remaining unusual variable types - convert any remaining unusual variable types
- find codes that can use %pM and %Nph formatting - find codes that can use %pM and %Nph formatting
- fix any reviewer's comments regarding movin the driver to drivers/net/wireless - checkpatch.pl fixes - most of the remaining ones are lines too long. Many
of them will require refactoring
- merge Realtek's bugfixes and new features into the driver
- address any reviewers comments
Please send any patches to Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Please send any patches to Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
and Larry Finger <Larry.Finger@lwfinger.net>. and Larry Finger <Larry.Finger@lwfinger.net>.

23
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c
View File

@ -791,18 +791,17 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
struct seq_file *m) struct seq_file *m)
{ {
struct rtl_priv *rtlpriv = btcoexist->adapter; struct rtl_priv *rtlpriv = btcoexist->adapter;
s32 wifi_rssi = 0, bt_hs_rssi = 0; s32 wifi_rssi = 0, bt_hs_rssi = 0;
bool scan = false, link = false, roam = false, wifi_busy = false, bool scan = false, link = false, roam = false, wifi_busy = false;
wifi_under_b_mode = false, bool wifi_under_b_mode = false, wifi_under_5g = false;
wifi_under_5g = false; u32 wifi_bw = BTC_WIFI_BW_HT20;
u32 wifi_bw = BTC_WIFI_BW_HT20, u32 wifi_traffic_dir = BTC_WIFI_TRAFFIC_TX;
wifi_traffic_dir = BTC_WIFI_TRAFFIC_TX, u32 wifi_freq = BTC_FREQ_2_4G;
wifi_freq = BTC_FREQ_2_4G; u32 wifi_link_status = 0x0;
u32 wifi_link_status = 0x0; bool bt_hs_on = false, under_ips = false, under_lps = false;
bool bt_hs_on = false, under_ips = false, under_lps = false, bool low_power = false, dc_mode = false;
low_power = false, dc_mode = false; u8 wifi_chnl = 0, wifi_hs_chnl = 0, fw_ps_state;
u8 wifi_chnl = 0, wifi_hs_chnl = 0, fw_ps_state; u8 ap_num = 0;
u8 ap_num = 0;
wifi_link_status = halbtc_get_wifi_link_status(btcoexist); wifi_link_status = halbtc_get_wifi_link_status(btcoexist);
seq_printf(m, "\n %-35s = %d/ %d/ %d/ %d/ %d", seq_printf(m, "\n %-35s = %d/ %d/ %d/ %d/ %d",

5
drivers/staging/rtlwifi/debug.c
View File

@ -511,10 +511,7 @@ void rtl_debug_add_one(struct ieee80211_hw *hw)
rtlpriv->dbg.msg_buf = vzalloc(80 * 25); rtlpriv->dbg.msg_buf = vzalloc(80 * 25);
snprintf(rtlpriv->dbg.debugfs_name, 18, "%02x-%02x-%02x-%02x-%02x-%02x", snprintf(rtlpriv->dbg.debugfs_name, 18, "%pMF", rtlefuse->dev_addr);
rtlefuse->dev_addr[0], rtlefuse->dev_addr[1],
rtlefuse->dev_addr[2], rtlefuse->dev_addr[3],
rtlefuse->dev_addr[4], rtlefuse->dev_addr[5]);
rtlpriv->dbg.debugfs_dir = rtlpriv->dbg.debugfs_dir =
debugfs_create_dir(rtlpriv->dbg.debugfs_name, debugfs_topdir); debugfs_create_dir(rtlpriv->dbg.debugfs_name, debugfs_topdir);

2
drivers/staging/rtlwifi/rtl8822be/sw.c
View File

@ -432,7 +432,7 @@ static struct rtl_hal_cfg rtl8822be_hal_cfg = {
.maps[RTL_RC_VHT_RATE_2SS_MCS9] = DESC_RATEVHT2SS_MCS9, .maps[RTL_RC_VHT_RATE_2SS_MCS9] = DESC_RATEVHT2SS_MCS9,
}; };
static struct pci_device_id rtl8822be_pci_ids[] = { static const struct pci_device_id rtl8822be_pci_ids[] = {
{RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0xB822, rtl8822be_hal_cfg)}, {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0xB822, rtl8822be_hal_cfg)},
{}, {},
}; };