OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

brcm80211: smac: precendence bug in wlc_phy_attach() 

Negate has higher precendence than compare and since neither zero nor
one are equal to four or eight the original condition is always false.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Dan Carpenter 2011-12-15 14:23:32 +03:00 committed by John W. Linville
parent 29942bc125
commit aa1f2f0a32
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
View File

@ -482,8 +482,8 @@ wlc_phy_attach(struct shared_phy *sh, struct bcma_device *d11core,
pi->pubpi.phy_corenum = PHY_CORE_NUM_2; pi->pubpi.phy_corenum = PHY_CORE_NUM_2;
pi->pubpi.ana_rev = (phyversion & PV_AV_MASK) >> PV_AV_SHIFT; pi->pubpi.ana_rev = (phyversion & PV_AV_MASK) >> PV_AV_SHIFT;
if (!pi->pubpi.phy_type == PHY_TYPE_N && if (pi->pubpi.phy_type != PHY_TYPE_N &&
!pi->pubpi.phy_type == PHY_TYPE_LCN) pi->pubpi.phy_type != PHY_TYPE_LCN)
goto err; goto err;
if (bandtype == BRCM_BAND_5G) { if (bandtype == BRCM_BAND_5G) {