OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tpm/tpm_crb: cache cmd_size register value. 

Instead of expensive register access on retrieving cmd_size
on each send, save the value during initialization in the private
context. The value doesn't change.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
This commit is contained in:
Tomas Winkler 2016-09-12 13:52:10 +03:00 committed by Jarkko Sakkinen
parent 71801310b1
commit aa77ea0e43
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/char/tpm/tpm_crb.c
View File

@ -80,6 +80,7 @@ struct crb_priv {
struct crb_control_area __iomem *cca; struct crb_control_area __iomem *cca;
u8 __iomem *cmd; u8 __iomem *cmd;
u8 __iomem *rsp; u8 __iomem *rsp;
u32 cmd_size;
}; };
static SIMPLE_DEV_PM_OPS(crb_pm, tpm_pm_suspend, tpm_pm_resume); static SIMPLE_DEV_PM_OPS(crb_pm, tpm_pm_suspend, tpm_pm_resume);
@ -146,11 +147,9 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, size_t len)
*/ */
iowrite32(0, &priv->cca->cancel); iowrite32(0, &priv->cca->cancel);
if (len > ioread32(&priv->cca->cmd_size)) { if (len > priv->cmd_size) {
dev_err(&chip->dev, dev_err(&chip->dev, "invalid command count value %zd %d\n",
"invalid command count value %x %zx\n", len, priv->cmd_size);
(unsigned int) len,
(size_t) ioread32(&priv->cca->cmd_size));
return -E2BIG; return -E2BIG;
} }
@ -301,6 +300,7 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv,
dev_err(dev, FW_BUG "overlapping command and response buffer sizes are not identical"); dev_err(dev, FW_BUG "overlapping command and response buffer sizes are not identical");
return -EINVAL; return -EINVAL;
} }
priv->cmd_size = cmd_size;
priv->rsp = priv->cmd; priv->rsp = priv->cmd;
return 0; return 0;