OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] aha152x: fix init suspiciously returned 1, it should follow 0/-E convention 

Reported-by: Frank de Jong <frapex@xs4all.nl>
> [1.] One line summary of the problem:
> linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should
> follow 0/-E convention. The module / driver works okay. Unloading the
> module is impossible.

The driver is apparently returning 0 on failure and 1 on success.
That's a bit unfortunate.  Fix it by altering to -ENODEV and 0.

Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
James Bottomley 2008-05-10 08:33:58 -05:00
parent c8611f9754
commit ad2fa42d04
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/aha152x.c
View File

@ -3830,7 +3830,7 @@ static int __init aha152x_init(void)
iounmap(p);
}
if (!ok && setup_count == 0)
return 0;
return -ENODEV;
printk(KERN_INFO "aha152x: BIOS test: passed, ");
#else
@ -3909,7 +3909,7 @@ static int __init aha152x_init(void)
#endif
}
return 1;
return 0;
}
static void __exit aha152x_exit(void)