spi: bcm-qspi: Fix missing clk_disable_unprepare() on error in bcm_qspi_probe()
[ Upstream commit ca9b8f56ec089d3a436050afefd17b7237301f47 ] Fix the missing clk_disable_unprepare() before return from bcm_qspi_probe() in the error handling case. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20211018073413.2029081-1-yangyingliang@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
a15fc58933
commit
ad67a7e2ab
|
@ -1300,7 +1300,7 @@ int bcm_qspi_probe(struct platform_device *pdev,
|
||||||
&qspi->dev_ids[val]);
|
&qspi->dev_ids[val]);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
dev_err(&pdev->dev, "IRQ %s not found\n", name);
|
dev_err(&pdev->dev, "IRQ %s not found\n", name);
|
||||||
goto qspi_probe_err;
|
goto qspi_unprepare_err;
|
||||||
}
|
}
|
||||||
|
|
||||||
qspi->dev_ids[val].dev = qspi;
|
qspi->dev_ids[val].dev = qspi;
|
||||||
|
@ -1315,7 +1315,7 @@ int bcm_qspi_probe(struct platform_device *pdev,
|
||||||
if (!num_ints) {
|
if (!num_ints) {
|
||||||
dev_err(&pdev->dev, "no IRQs registered, cannot init driver\n");
|
dev_err(&pdev->dev, "no IRQs registered, cannot init driver\n");
|
||||||
ret = -EINVAL;
|
ret = -EINVAL;
|
||||||
goto qspi_probe_err;
|
goto qspi_unprepare_err;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
@ -1359,6 +1359,7 @@ int bcm_qspi_probe(struct platform_device *pdev,
|
||||||
|
|
||||||
qspi_reg_err:
|
qspi_reg_err:
|
||||||
bcm_qspi_hw_uninit(qspi);
|
bcm_qspi_hw_uninit(qspi);
|
||||||
|
qspi_unprepare_err:
|
||||||
clk_disable_unprepare(qspi->clk);
|
clk_disable_unprepare(qspi->clk);
|
||||||
qspi_probe_err:
|
qspi_probe_err:
|
||||||
kfree(qspi->dev_ids);
|
kfree(qspi->dev_ids);
|
||||||
|
|
Loading…
Reference in New Issue