selinux: fix double free
commit 65de50969a
upstream.
Clang's static analysis tool reports these double free memory errors.
security/selinux/ss/services.c:2987:4: warning: Attempt to free released memory [unix.Malloc]
kfree(bnames[i]);
^~~~~~~~~~~~~~~~
security/selinux/ss/services.c:2990:2: warning: Attempt to free released memory [unix.Malloc]
kfree(bvalues);
^~~~~~~~~~~~~~
So improve the security_get_bools error handling by freeing these variables
and setting their return pointers to NULL and the return len to 0
Cc: stable@vger.kernel.org
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
5471b5287c
commit
ae3c09e346
|
@ -2844,8 +2844,12 @@ err:
|
|||
if (*names) {
|
||||
for (i = 0; i < *len; i++)
|
||||
kfree((*names)[i]);
|
||||
kfree(*names);
|
||||
}
|
||||
kfree(*values);
|
||||
*len = 0;
|
||||
*names = NULL;
|
||||
*values = NULL;
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue