OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bus: bt1-apb: Use sysfs_streq instead of strncmp

Browse Source 
There is a ready-to-use method to compare a retrieved from a sysfs node
string with another string. It treats both NUL and newline-then-NUL as
equivalent string terminations. So use it instead of manually truncating
the line length in the strncmp() method.

Link: https://lore.kernel.org/r/20200528145050.5203-4-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: soc@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This commit is contained in:
Serge Semin 2020-05-28 17:50:48 +03:00 committed by Arnd Bergmann
parent 75341b3d35
commit b7cb430d5f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/bus/bt1-apb.c
View File

@ -325,9 +325,9 @@ static ssize_t inject_error_store(struct device *dev,
* Either dummy read from the unmapped address in the APB IO area
* or manually set the IRQ status.
*/
if (!strncmp(data, "nodev", 5))
if (sysfs_streq(data, "nodev"))
readl(apb->res);
else if (!strncmp(data, "irq", 3))
else if (sysfs_streq(data, "irq"))
regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING,
APB_EHB_ISR_PENDING);
else