drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c
This file is built for a bool Kconfig variable, and hence this code is either present or absent. It currently can never be modular, so using module_init as an alias for __initcall can be somewhat misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of device_initcall directly in this change means that the runtime impact is zero -- it will remain at level 6 in initcall ordering. And since it can't be modular, we remove all the __exitcall stuff related to module_exit() -- it is dead code that won't ever be executed. Cc: Richard Purdie <rpurdie@rpsys.net> Cc: linux-leds@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com> Signed-off-by: Bryan Wu <cooloney@gmail.com>
This commit is contained in:
parent
ac69b9038f
commit
b83fae0c0c
|
@ -108,20 +108,8 @@ err_null:
|
||||||
return retval;
|
return retval;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int cobalt_raq_led_remove(struct platform_device *pdev)
|
|
||||||
{
|
|
||||||
led_classdev_unregister(&raq_power_off_led);
|
|
||||||
led_classdev_unregister(&raq_web_led);
|
|
||||||
|
|
||||||
if (led_port)
|
|
||||||
led_port = NULL;
|
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
static struct platform_driver cobalt_raq_led_driver = {
|
static struct platform_driver cobalt_raq_led_driver = {
|
||||||
.probe = cobalt_raq_led_probe,
|
.probe = cobalt_raq_led_probe,
|
||||||
.remove = cobalt_raq_led_remove,
|
|
||||||
.driver = {
|
.driver = {
|
||||||
.name = "cobalt-raq-leds",
|
.name = "cobalt-raq-leds",
|
||||||
},
|
},
|
||||||
|
@ -131,5 +119,4 @@ static int __init cobalt_raq_led_init(void)
|
||||||
{
|
{
|
||||||
return platform_driver_register(&cobalt_raq_led_driver);
|
return platform_driver_register(&cobalt_raq_led_driver);
|
||||||
}
|
}
|
||||||
|
device_initcall(cobalt_raq_led_init);
|
||||||
module_init(cobalt_raq_led_init);
|
|
||||||
|
|
Loading…
Reference in New Issue