abx500_chargalg: Reorder obtainment of platform specific battery management data

Now that we always pass platform specific battery management data
through platform_data instead of obtaining it via different means
depending the way be boot the system (DT or ATAGs); we need to
re-jiggle the way we acquire it in the driver start-up functions.
Now it is wrong for it to be missing, but we still allow Device
Tree code to fiddle with it once we've confirmed it's there.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Lee Jones 2012-11-30 10:57:14 +00:00
parent 195c1c660c
commit bdc56b4403
1 changed files with 13 additions and 14 deletions

View File

@ -1806,6 +1806,7 @@ static char *supply_interface[] = {
static int __devinit abx500_chargalg_probe(struct platform_device *pdev) static int __devinit abx500_chargalg_probe(struct platform_device *pdev)
{ {
struct device_node *np = pdev->dev.of_node; struct device_node *np = pdev->dev.of_node;
struct abx500_bm_data *plat = pdev->dev.platform_data;
struct abx500_chargalg *di; struct abx500_chargalg *di;
int ret = 0; int ret = 0;
@ -1814,21 +1815,19 @@ static int __devinit abx500_chargalg_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "%s no mem for ab8500_chargalg\n", __func__); dev_err(&pdev->dev, "%s no mem for ab8500_chargalg\n", __func__);
return -ENOMEM; return -ENOMEM;
} }
di->bm = pdev->mfd_cell->platform_data;
if (!di->bm) { if (!plat) {
if (np) { dev_err(&pdev->dev, "no battery management data supplied\n");
ret = ab8500_bm_of_probe(&pdev->dev, np, di->bm); return -EINVAL;
if (ret) { }
dev_err(&pdev->dev, di->bm = plat;
"failed to get battery information\n");
return ret; if (np) {
} ret = ab8500_bm_of_probe(&pdev->dev, np, di->bm);
} else { if (ret) {
dev_err(&pdev->dev, "missing dt node for ab8500_chargalg\n"); dev_err(&pdev->dev, "failed to get battery information\n");
return -EINVAL; return ret;
} }
} else {
dev_info(&pdev->dev, "falling back to legacy platform data\n");
} }
/* get device struct */ /* get device struct */