leds: leds-hp6xx: Use devm_led_classdev_register
Use resource-managed function devm_led_classdev_register instead of led_classdev_register to simplify error path. An unnecessary check of ret is replaced with a direct return Also, remove redundant hp6xxled_remove. Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
This commit is contained in:
parent
aa4e252495
commit
c0fc68ba97
|
@ -59,28 +59,15 @@ static int hp6xxled_probe(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
ret = led_classdev_register(&pdev->dev, &hp6xx_red_led);
|
ret = devm_led_classdev_register(&pdev->dev, &hp6xx_red_led);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
return ret;
|
return ret;
|
||||||
|
|
||||||
ret = led_classdev_register(&pdev->dev, &hp6xx_green_led);
|
return devm_led_classdev_register(&pdev->dev, &hp6xx_green_led);
|
||||||
if (ret < 0)
|
|
||||||
led_classdev_unregister(&hp6xx_red_led);
|
|
||||||
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
|
|
||||||
static int hp6xxled_remove(struct platform_device *pdev)
|
|
||||||
{
|
|
||||||
led_classdev_unregister(&hp6xx_red_led);
|
|
||||||
led_classdev_unregister(&hp6xx_green_led);
|
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct platform_driver hp6xxled_driver = {
|
static struct platform_driver hp6xxled_driver = {
|
||||||
.probe = hp6xxled_probe,
|
.probe = hp6xxled_probe,
|
||||||
.remove = hp6xxled_remove,
|
|
||||||
.driver = {
|
.driver = {
|
||||||
.name = "hp6xx-led",
|
.name = "hp6xx-led",
|
||||||
},
|
},
|
||||||
|
|
Loading…
Reference in New Issue