scsi: libsas: align sata_device's rps_resp on a cacheline
The rps_resp buffer in ata_device is a DMA target, but it isn't explicitly cacheline aligned. Due to this, adjacent fields can be overwritten with stale data from memory on non-coherent architectures. As a result, the kernel is sometimes unable to communicate with an SATA device behind a SAS expander. Fix this by ensuring that the rps_resp buffer is cacheline aligned. This issue is similar to that fixed by Commit84bda12af3
("libata: align ap->sector_buf") and Commit4ee34ea3a1
("libata: Align ata_device's id on a cacheline"). Cc: stable@vger.kernel.org Signed-off-by: Huacai Chen <chenhc@lemote.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
90addc6b3c
commit
c2e8fbf908
|
@ -159,11 +159,11 @@ struct expander_device {
|
|||
|
||||
struct sata_device {
|
||||
unsigned int class;
|
||||
struct smp_resp rps_resp; /* report_phy_sata_resp */
|
||||
u8 port_no; /* port number, if this is a PM (Port) */
|
||||
|
||||
struct ata_port *ap;
|
||||
struct ata_host ata_host;
|
||||
struct smp_resp rps_resp ____cacheline_aligned; /* report_phy_sata_resp */
|
||||
u8 fis[ATA_RESP_FIS_SIZE];
|
||||
};
|
||||
|
||||
|
|
Loading…
Reference in New Issue