OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[AGPGART] Prevent (unlikely) memory leak in amd_create_gatt_pages()

Browse Source 
If we fail an alloc, unwind the previous allocs that succeeded.

Spotted-by: Alan Grimes <agrimes@speakeasy.net>
Signed-off-by: Dave Jones <davej@redhat.com>
This commit is contained in:
Dave Jones 2007-01-28 17:39:19 -05:00
parent 4b95320fc4
commit c30efbaeaa
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/char/agp/amd-k7-agp.c
View File

@ -101,6 +101,11 @@ static int amd_create_gatt_pages(int nr_tables)
for (i = 0; i < nr_tables; i++) {
entry = kzalloc(sizeof(struct amd_page_map), GFP_KERNEL);
if (entry == NULL) {
while (i > 0) {
kfree(tables[i-1]);
i--;
}
kfree(tables);
retval = -ENOMEM;
break;
}