vfio/pci: return -EFAULT if copy_to_user fails

The copy_to_user() function returns the number of bytes that were not
copied but we want to return -EFAULT on error here.

Fixes: 188ad9d6cb ('vfio/pci: Include sparse mmap capability for MSI-X table regions')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Dan Carpenter 2016-02-25 10:52:12 +03:00 committed by Alex Williamson
parent a13b645917
commit c4aec31013
1 changed files with 4 additions and 5 deletions

View File

@ -664,12 +664,11 @@ static long vfio_pci_ioctl(void *device_data,
info.cap_offset = 0;
} else {
vfio_info_cap_shift(&caps, sizeof(info));
ret = copy_to_user((void __user *)arg +
sizeof(info), caps.buf,
caps.size);
if (ret) {
if (copy_to_user((void __user *)arg +
sizeof(info), caps.buf,
caps.size)) {
kfree(caps.buf);
return ret;
return -EFAULT;
}
info.cap_offset = sizeof(info);
}