x86/gart: Tidy messages and add bridge device info
Print the AGP bridge info the same way as the rest of the kernel, e.g., "0000:00:04.0" instead of "00:04:00". Also print the AGP aperture address range the same way we print resources, and label it explicitly as a bus address range. No functional change except the message changes. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
parent
a5d3244a0b
commit
c96ec95315
|
@ -77,13 +77,13 @@ static u32 __init allocate_aperture(void)
|
||||||
addr = memblock_find_in_range(GART_MIN_ADDR, GART_MAX_ADDR,
|
addr = memblock_find_in_range(GART_MIN_ADDR, GART_MAX_ADDR,
|
||||||
aper_size, aper_size);
|
aper_size, aper_size);
|
||||||
if (!addr) {
|
if (!addr) {
|
||||||
pr_err("Cannot allocate aperture memory hole (%lx,%uK)\n",
|
pr_err("Cannot allocate aperture memory hole [mem %#010lx-%#010lx] (%uKB)\n",
|
||||||
addr, aper_size>>10);
|
addr, addr + aper_size - 1, aper_size >> 10);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
memblock_reserve(addr, aper_size);
|
memblock_reserve(addr, aper_size);
|
||||||
pr_info("Mapping aperture over %d KB of RAM @ %lx\n", aper_size >> 10,
|
pr_info("Mapping aperture over RAM [mem %#010lx-%#010lx] (%uKB)\n",
|
||||||
addr);
|
addr, addr + aper_size - 1, aper_size >> 10);
|
||||||
register_nosave_region(addr >> PAGE_SHIFT,
|
register_nosave_region(addr >> PAGE_SHIFT,
|
||||||
(addr+aper_size) >> PAGE_SHIFT);
|
(addr+aper_size) >> PAGE_SHIFT);
|
||||||
|
|
||||||
|
@ -127,10 +127,11 @@ static u32 __init read_agp(int bus, int slot, int func, int cap, u32 *order)
|
||||||
u64 aper;
|
u64 aper;
|
||||||
u32 old_order;
|
u32 old_order;
|
||||||
|
|
||||||
pr_info("AGP bridge at %02x:%02x:%02x\n", bus, slot, func);
|
pr_info("pci 0000:%02x:%02x:%02x: AGP bridge\n", bus, slot, func);
|
||||||
apsizereg = read_pci_config_16(bus, slot, func, cap + 0x14);
|
apsizereg = read_pci_config_16(bus, slot, func, cap + 0x14);
|
||||||
if (apsizereg == 0xffffffff) {
|
if (apsizereg == 0xffffffff) {
|
||||||
pr_err("APSIZE in AGP bridge unreadable\n");
|
pr_err("pci 0000:%02x:%02x.%d: APSIZE unreadable\n",
|
||||||
|
bus, slot, func);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -154,15 +155,17 @@ static u32 __init read_agp(int bus, int slot, int func, int cap, u32 *order)
|
||||||
* On some sick chips, APSIZE is 0. It means it wants 4G
|
* On some sick chips, APSIZE is 0. It means it wants 4G
|
||||||
* so let double check that order, and lets trust AMD NB settings:
|
* so let double check that order, and lets trust AMD NB settings:
|
||||||
*/
|
*/
|
||||||
pr_info("Aperture from AGP @ %Lx old size %u MB\n",
|
pr_info("pci 0000:%02x:%02x.%d: AGP aperture [bus addr %#010Lx-%#010Lx] (old size %uMB)\n",
|
||||||
aper, 32 << old_order);
|
bus, slot, func, aper, aper + (32ULL << (old_order + 20)) - 1,
|
||||||
|
32 << old_order);
|
||||||
if (aper + (32ULL<<(20 + *order)) > 0x100000000ULL) {
|
if (aper + (32ULL<<(20 + *order)) > 0x100000000ULL) {
|
||||||
pr_info("Aperture size %u MB (APSIZE %x) is not right, using settings from NB\n",
|
pr_info("pci 0000:%02x:%02x.%d: AGP aperture size %uMB (APSIZE %#x) is not right, using settings from NB\n",
|
||||||
32 << *order, apsizereg);
|
bus, slot, func, 32 << *order, apsizereg);
|
||||||
*order = old_order;
|
*order = old_order;
|
||||||
}
|
}
|
||||||
|
|
||||||
pr_info("Aperture from AGP @ %Lx size %u MB (APSIZE %x)\n", aper,
|
pr_info("pci 0000:%02x:%02x.%d: AGP aperture [bus addr %#010Lx-%#010Lx] (%uMB, APSIZE %#x)\n",
|
||||||
|
bus, slot, func, aper, aper + (32ULL << (*order + 20)) - 1,
|
||||||
32 << *order, apsizereg);
|
32 << *order, apsizereg);
|
||||||
|
|
||||||
if (!aperture_valid(aper, (32*1024*1024) << *order, 32<<20))
|
if (!aperture_valid(aper, (32*1024*1024) << *order, 32<<20))
|
||||||
|
@ -311,7 +314,8 @@ void __init early_gart_iommu_check(void)
|
||||||
if (e820_any_mapped(aper_base, aper_base + aper_size,
|
if (e820_any_mapped(aper_base, aper_base + aper_size,
|
||||||
E820_RAM)) {
|
E820_RAM)) {
|
||||||
/* reserve it, so we can reuse it in second kernel */
|
/* reserve it, so we can reuse it in second kernel */
|
||||||
pr_info("update e820 for GART\n");
|
pr_info("e820: reserve [mem %#010Lx-%#010Lx] for GART\n",
|
||||||
|
aper_base, aper_base + aper_size - 1);
|
||||||
e820_add_region(aper_base, aper_size, E820_RESERVED);
|
e820_add_region(aper_base, aper_size, E820_RESERVED);
|
||||||
update_e820();
|
update_e820();
|
||||||
}
|
}
|
||||||
|
@ -396,8 +400,9 @@ int __init gart_iommu_hole_init(void)
|
||||||
aper_base = read_pci_config(bus, slot, 3, AMD64_GARTAPERTUREBASE) & 0x7fff;
|
aper_base = read_pci_config(bus, slot, 3, AMD64_GARTAPERTUREBASE) & 0x7fff;
|
||||||
aper_base <<= 25;
|
aper_base <<= 25;
|
||||||
|
|
||||||
pr_info("Node %d: aperture @ %Lx size %u MB\n",
|
pr_info("Node %d: aperture [bus addr %#010Lx-%#010Lx] (%uMB)\n",
|
||||||
node, aper_base, aper_size >> 20);
|
node, aper_base, aper_base + aper_size - 1,
|
||||||
|
aper_size >> 20);
|
||||||
node++;
|
node++;
|
||||||
|
|
||||||
if (!aperture_valid(aper_base, aper_size, 64<<20)) {
|
if (!aperture_valid(aper_base, aper_size, 64<<20)) {
|
||||||
|
@ -408,7 +413,7 @@ int __init gart_iommu_hole_init(void)
|
||||||
if (!no_iommu &&
|
if (!no_iommu &&
|
||||||
max_pfn > MAX_DMA32_PFN &&
|
max_pfn > MAX_DMA32_PFN &&
|
||||||
!printed_gart_size_msg) {
|
!printed_gart_size_msg) {
|
||||||
pr_err("you are using iommu with agp, but GART size is less than 64M\n");
|
pr_err("you are using iommu with agp, but GART size is less than 64MB\n");
|
||||||
pr_err("please increase GART size in your BIOS setup\n");
|
pr_err("please increase GART size in your BIOS setup\n");
|
||||||
pr_err("if BIOS doesn't have that option, contact your HW vendor!\n");
|
pr_err("if BIOS doesn't have that option, contact your HW vendor!\n");
|
||||||
printed_gart_size_msg = 1;
|
printed_gart_size_msg = 1;
|
||||||
|
@ -449,7 +454,7 @@ out:
|
||||||
fallback_aper_force) {
|
fallback_aper_force) {
|
||||||
pr_info("Your BIOS doesn't leave a aperture memory hole\n");
|
pr_info("Your BIOS doesn't leave a aperture memory hole\n");
|
||||||
pr_info("Please enable the IOMMU option in the BIOS setup\n");
|
pr_info("Please enable the IOMMU option in the BIOS setup\n");
|
||||||
pr_info("This costs you %d MB of RAM\n",
|
pr_info("This costs you %dMB of RAM\n",
|
||||||
32 << fallback_aper_order);
|
32 << fallback_aper_order);
|
||||||
|
|
||||||
aper_order = fallback_aper_order;
|
aper_order = fallback_aper_order;
|
||||||
|
|
Loading…
Reference in New Issue