OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mm/memory_hotplug: is_mem_section_removable() can return bool 

Make is_mem_section_removable() return bool to improve readability due
to this particular function only using either one or zero as its return
value.

Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Yaowei Bai 2016-05-19 17:11:26 -07:00 committed by Linus Torvalds
parent 32f6271dbd
commit c98940f6fa
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/memory_hotplug.h
View File

@ -247,16 +247,16 @@ static inline void mem_hotplug_done(void) {}
#ifdef CONFIG_MEMORY_HOTREMOVE #ifdef CONFIG_MEMORY_HOTREMOVE
extern int is_mem_section_removable(unsigned long pfn, unsigned long nr_pages); extern bool is_mem_section_removable(unsigned long pfn, unsigned long nr_pages);
extern void try_offline_node(int nid); extern void try_offline_node(int nid);
extern int offline_pages(unsigned long start_pfn, unsigned long nr_pages); extern int offline_pages(unsigned long start_pfn, unsigned long nr_pages);
extern void remove_memory(int nid, u64 start, u64 size); extern void remove_memory(int nid, u64 start, u64 size);
#else #else
static inline int is_mem_section_removable(unsigned long pfn, static inline bool is_mem_section_removable(unsigned long pfn,
unsigned long nr_pages) unsigned long nr_pages)
{ {
return 0; return false;
} }
static inline void try_offline_node(int nid) {} static inline void try_offline_node(int nid) {}

6
mm/memory_hotplug.c
View File

@ -1410,7 +1410,7 @@ static struct page *next_active_pageblock(struct page *page)
} }
/* Checks if this range of memory is likely to be hot-removable. */ /* Checks if this range of memory is likely to be hot-removable. */
int is_mem_section_removable(unsigned long start_pfn, unsigned long nr_pages) bool is_mem_section_removable(unsigned long start_pfn, unsigned long nr_pages)
{ {
struct page *page = pfn_to_page(start_pfn); struct page *page = pfn_to_page(start_pfn);
struct page *end_page = page + nr_pages; struct page *end_page = page + nr_pages;
@ -1418,12 +1418,12 @@ int is_mem_section_removable(unsigned long start_pfn, unsigned long nr_pages)
/* Check the starting page of each pageblock within the range */ /* Check the starting page of each pageblock within the range */
for (; page < end_page; page = next_active_pageblock(page)) { for (; page < end_page; page = next_active_pageblock(page)) {
if (!is_pageblock_removable_nolock(page)) if (!is_pageblock_removable_nolock(page))
return 0; return false;
cond_resched(); cond_resched();
} }
/* All pageblocks in the memory block are likely to be hot-removable */ /* All pageblocks in the memory block are likely to be hot-removable */
return 1; return true;
} }
/* /*