ALSA: ad1889: constify snd_pcm_ops structures
Check for snd_pcm_ops structures that are only stored in the ops field of a snd_soc_platform_driver structure or passed as the third argument to snd_pcm_set_ops. The corresponding field or parameter is declared const, so snd_pcm_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct snd_pcm_ops i@p = { ... }; @ok1@ identifier r.i; struct snd_soc_platform_driver e; position p; @@ e.ops = &i@p; @ok2@ identifier r.i; expression e1, e2; position p; @@ snd_pcm_set_ops(e1, e2, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; struct snd_pcm_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct snd_pcm_ops i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
5116ffc32d
commit
d602efcaf5
|
@ -571,7 +571,7 @@ snd_ad1889_capture_pointer(struct snd_pcm_substream *ss)
|
||||||
return bytes_to_frames(ss->runtime, ptr);
|
return bytes_to_frames(ss->runtime, ptr);
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct snd_pcm_ops snd_ad1889_playback_ops = {
|
static const struct snd_pcm_ops snd_ad1889_playback_ops = {
|
||||||
.open = snd_ad1889_playback_open,
|
.open = snd_ad1889_playback_open,
|
||||||
.close = snd_ad1889_playback_close,
|
.close = snd_ad1889_playback_close,
|
||||||
.ioctl = snd_pcm_lib_ioctl,
|
.ioctl = snd_pcm_lib_ioctl,
|
||||||
|
@ -582,7 +582,7 @@ static struct snd_pcm_ops snd_ad1889_playback_ops = {
|
||||||
.pointer = snd_ad1889_playback_pointer,
|
.pointer = snd_ad1889_playback_pointer,
|
||||||
};
|
};
|
||||||
|
|
||||||
static struct snd_pcm_ops snd_ad1889_capture_ops = {
|
static const struct snd_pcm_ops snd_ad1889_capture_ops = {
|
||||||
.open = snd_ad1889_capture_open,
|
.open = snd_ad1889_capture_open,
|
||||||
.close = snd_ad1889_capture_close,
|
.close = snd_ad1889_capture_close,
|
||||||
.ioctl = snd_pcm_lib_ioctl,
|
.ioctl = snd_pcm_lib_ioctl,
|
||||||
|
|
Loading…
Reference in New Issue