From d8dfab0f4d0669ae299511e3ab3e79f312476f75 Mon Sep 17 00:00:00 2001 From: Anson Huang Date: Fri, 24 May 2019 13:51:00 +0800 Subject: [PATCH] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling of_node_put() is called after of_match_node() successfully called, then in the following error handling, of_node_put() is called again which is unnecessary, this patch adjusts the location of of_node_put() to avoid such scenario. Signed-off-by: Anson Huang Reviewed-by: Leonard Crestez Signed-off-by: Shawn Guo --- drivers/soc/imx/soc-imx8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c index cd10726e64e4..d377a90f3a2f 100644 --- a/drivers/soc/imx/soc-imx8.c +++ b/drivers/soc/imx/soc-imx8.c @@ -115,8 +115,6 @@ static int __init imx8_soc_init(void) if (!id) goto free_soc; - of_node_put(root); - data = id->data; if (data) { soc_dev_attr->soc_id = data->name; @@ -132,6 +130,8 @@ static int __init imx8_soc_init(void) if (IS_ERR(soc_dev)) goto free_rev; + of_node_put(root); + return 0; free_rev: