ALSA: firewire-tascam: code refactoring for pcm.hw_params/hw_free callbacks
The pairs of pcm.hw_params callbacks and .hw_free callbacks for both direction have no differences. This commit unifies the pairs. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
ece92831f0
commit
d8f291b7b8
|
@ -84,8 +84,8 @@ static int pcm_close(struct snd_pcm_substream *substream)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int pcm_capture_hw_params(struct snd_pcm_substream *substream,
|
static int pcm_hw_params(struct snd_pcm_substream *substream,
|
||||||
struct snd_pcm_hw_params *hw_params)
|
struct snd_pcm_hw_params *hw_params)
|
||||||
{
|
{
|
||||||
struct snd_tscm *tscm = substream->private_data;
|
struct snd_tscm *tscm = substream->private_data;
|
||||||
int err;
|
int err;
|
||||||
|
@ -108,48 +108,7 @@ static int pcm_capture_hw_params(struct snd_pcm_substream *substream,
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int pcm_playback_hw_params(struct snd_pcm_substream *substream,
|
static int pcm_hw_free(struct snd_pcm_substream *substream)
|
||||||
struct snd_pcm_hw_params *hw_params)
|
|
||||||
{
|
|
||||||
struct snd_tscm *tscm = substream->private_data;
|
|
||||||
int err;
|
|
||||||
|
|
||||||
err = snd_pcm_lib_alloc_vmalloc_buffer(substream,
|
|
||||||
params_buffer_bytes(hw_params));
|
|
||||||
if (err < 0)
|
|
||||||
return err;
|
|
||||||
|
|
||||||
if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN) {
|
|
||||||
unsigned int rate = params_rate(hw_params);
|
|
||||||
|
|
||||||
mutex_lock(&tscm->mutex);
|
|
||||||
err = snd_tscm_stream_reserve_duplex(tscm, rate);
|
|
||||||
if (err >= 0)
|
|
||||||
++tscm->substreams_counter;
|
|
||||||
mutex_unlock(&tscm->mutex);
|
|
||||||
}
|
|
||||||
|
|
||||||
return err;
|
|
||||||
}
|
|
||||||
|
|
||||||
static int pcm_capture_hw_free(struct snd_pcm_substream *substream)
|
|
||||||
{
|
|
||||||
struct snd_tscm *tscm = substream->private_data;
|
|
||||||
|
|
||||||
mutex_lock(&tscm->mutex);
|
|
||||||
|
|
||||||
if (substream->runtime->status->state != SNDRV_PCM_STATE_OPEN)
|
|
||||||
--tscm->substreams_counter;
|
|
||||||
|
|
||||||
snd_tscm_stream_stop_duplex(tscm);
|
|
||||||
snd_tscm_stream_release_duplex(tscm);
|
|
||||||
|
|
||||||
mutex_unlock(&tscm->mutex);
|
|
||||||
|
|
||||||
return snd_pcm_lib_free_vmalloc_buffer(substream);
|
|
||||||
}
|
|
||||||
|
|
||||||
static int pcm_playback_hw_free(struct snd_pcm_substream *substream)
|
|
||||||
{
|
{
|
||||||
struct snd_tscm *tscm = substream->private_data;
|
struct snd_tscm *tscm = substream->private_data;
|
||||||
|
|
||||||
|
@ -270,8 +229,8 @@ int snd_tscm_create_pcm_devices(struct snd_tscm *tscm)
|
||||||
.open = pcm_open,
|
.open = pcm_open,
|
||||||
.close = pcm_close,
|
.close = pcm_close,
|
||||||
.ioctl = snd_pcm_lib_ioctl,
|
.ioctl = snd_pcm_lib_ioctl,
|
||||||
.hw_params = pcm_capture_hw_params,
|
.hw_params = pcm_hw_params,
|
||||||
.hw_free = pcm_capture_hw_free,
|
.hw_free = pcm_hw_free,
|
||||||
.prepare = pcm_capture_prepare,
|
.prepare = pcm_capture_prepare,
|
||||||
.trigger = pcm_capture_trigger,
|
.trigger = pcm_capture_trigger,
|
||||||
.pointer = pcm_capture_pointer,
|
.pointer = pcm_capture_pointer,
|
||||||
|
@ -282,8 +241,8 @@ int snd_tscm_create_pcm_devices(struct snd_tscm *tscm)
|
||||||
.open = pcm_open,
|
.open = pcm_open,
|
||||||
.close = pcm_close,
|
.close = pcm_close,
|
||||||
.ioctl = snd_pcm_lib_ioctl,
|
.ioctl = snd_pcm_lib_ioctl,
|
||||||
.hw_params = pcm_playback_hw_params,
|
.hw_params = pcm_hw_params,
|
||||||
.hw_free = pcm_playback_hw_free,
|
.hw_free = pcm_hw_free,
|
||||||
.prepare = pcm_playback_prepare,
|
.prepare = pcm_playback_prepare,
|
||||||
.trigger = pcm_playback_trigger,
|
.trigger = pcm_playback_trigger,
|
||||||
.pointer = pcm_playback_pointer,
|
.pointer = pcm_playback_pointer,
|
||||||
|
|
Loading…
Reference in New Issue