i40e: Fix for blinking activity instead of link LEDs
This fix solves an issue occurring while calling i40e_led_set function from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identifying the port, since Activity LED may be blinking for different reasons as well. Signed-off-by: Michal Kuchta <michal.kuchta@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
parent
06aa040f03
commit
d95cd48060
|
@ -1486,6 +1486,7 @@ u32 i40e_led_get(struct i40e_hw *hw)
|
|||
case I40E_COMBINED_ACTIVITY:
|
||||
case I40E_FILTER_ACTIVITY:
|
||||
case I40E_MAC_ACTIVITY:
|
||||
case I40E_LINK_ACTIVITY:
|
||||
continue;
|
||||
default:
|
||||
break;
|
||||
|
@ -1534,6 +1535,7 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)
|
|||
case I40E_COMBINED_ACTIVITY:
|
||||
case I40E_FILTER_ACTIVITY:
|
||||
case I40E_MAC_ACTIVITY:
|
||||
case I40E_LINK_ACTIVITY:
|
||||
continue;
|
||||
default:
|
||||
break;
|
||||
|
@ -1544,9 +1546,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)
|
|||
gpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) &
|
||||
I40E_GLGEN_GPIO_CTL_LED_MODE_MASK);
|
||||
|
||||
if (mode == I40E_LINK_ACTIVITY)
|
||||
blink = false;
|
||||
|
||||
if (blink)
|
||||
gpio_val |= BIT(I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT);
|
||||
else
|
||||
|
|
Loading…
Reference in New Issue