vhost_net: re-poll only on EAGAIN or ENOBUFS
Currently, we restart tx polling unconditionally when sendmsg() fails. This would cause unnecessary wakeups of vhost wokers and waste cpu utlization when evil userspace(guest driver) is able to hit EFAULT or EINVAL. The polling is only needed when the socket send buffer were exceeded or not enough memory. So fix this by restarting polling only when sendmsg() returns EAGAIN/ENOBUFS. Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
c460f05739
commit
dbf34207c6
|
@ -257,7 +257,8 @@ static void handle_tx(struct vhost_net *net)
|
|||
UIO_MAXIOV;
|
||||
}
|
||||
vhost_discard_vq_desc(vq, 1);
|
||||
tx_poll_start(net, sock);
|
||||
if (err == -EAGAIN || err == -ENOBUFS)
|
||||
tx_poll_start(net, sock);
|
||||
break;
|
||||
}
|
||||
if (err != len)
|
||||
|
|
Loading…
Reference in New Issue