clk: rockchip: don't return NULL when registering inverter fails
Avoid return NULL if rockchip_clk_register_inverter fails, otherwise rockchip_clk_register_branches print "unknown clock type". The acutal case is that it's a known clock type but we fail to regiser it, which may makes user confuse the reason of failure. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
This commit is contained in:
parent
eb4e10c61d
commit
ddd02e1456
|
@ -90,7 +90,7 @@ struct clk *rockchip_clk_register_inverter(const char *name,
|
||||||
|
|
||||||
inv_clock = kmalloc(sizeof(*inv_clock), GFP_KERNEL);
|
inv_clock = kmalloc(sizeof(*inv_clock), GFP_KERNEL);
|
||||||
if (!inv_clock)
|
if (!inv_clock)
|
||||||
return NULL;
|
return ERR_PTR(-ENOMEM);
|
||||||
|
|
||||||
init.name = name;
|
init.name = name;
|
||||||
init.num_parents = num_parents;
|
init.num_parents = num_parents;
|
||||||
|
@ -106,11 +106,7 @@ struct clk *rockchip_clk_register_inverter(const char *name,
|
||||||
|
|
||||||
clk = clk_register(NULL, &inv_clock->hw);
|
clk = clk_register(NULL, &inv_clock->hw);
|
||||||
if (IS_ERR(clk))
|
if (IS_ERR(clk))
|
||||||
goto err_free;
|
kfree(inv_clock);
|
||||||
|
|
||||||
return clk;
|
return clk;
|
||||||
|
|
||||||
err_free:
|
|
||||||
kfree(inv_clock);
|
|
||||||
return NULL;
|
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue