USB: fix double kfree in ipaq in error case
in the error case the ipaq driver leaves a dangling pointer to already freed memory that will be freed again. Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
357585892e
commit
df3e1ab733
|
@ -646,12 +646,13 @@ static int ipaq_open(struct usb_serial_port *port, struct file *filp)
|
||||||
*/
|
*/
|
||||||
|
|
||||||
kfree(port->bulk_in_buffer);
|
kfree(port->bulk_in_buffer);
|
||||||
kfree(port->bulk_out_buffer);
|
|
||||||
port->bulk_in_buffer = kmalloc(URBDATA_SIZE, GFP_KERNEL);
|
port->bulk_in_buffer = kmalloc(URBDATA_SIZE, GFP_KERNEL);
|
||||||
if (port->bulk_in_buffer == NULL) {
|
if (port->bulk_in_buffer == NULL) {
|
||||||
port->bulk_out_buffer = NULL; /* prevent double free */
|
port->bulk_out_buffer = NULL; /* prevent double free */
|
||||||
goto enomem;
|
goto enomem;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
kfree(port->bulk_out_buffer);
|
||||||
port->bulk_out_buffer = kmalloc(URBDATA_SIZE, GFP_KERNEL);
|
port->bulk_out_buffer = kmalloc(URBDATA_SIZE, GFP_KERNEL);
|
||||||
if (port->bulk_out_buffer == NULL) {
|
if (port->bulk_out_buffer == NULL) {
|
||||||
kfree(port->bulk_in_buffer);
|
kfree(port->bulk_in_buffer);
|
||||||
|
|
Loading…
Reference in New Issue